[hareflow] Add hareflow #24903
Merged
[hareflow] Add hareflow #24903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yrivardmulrooney
force-pushed
the
hareflow
branch
from
8153770 to
d09cfae
Compare
yrivardmulrooney
force-pushed
the
hareflow
branch
from
d09cfae to
3ee6678
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/hareflow/vcpkg.json
Valid values for the license field can be found in the documentation
Adela0814
suggested changes
May 25, 2022
Adela0814
added
category:new-port
|
Hey, thank you for the review 👍 , I added what was requested and dropped the exclusion of x86-windows. I don't think I need a "supports" section in vcpkg.json now right? |
Adela0814
suggested changes
May 26, 2022
Yes！ |
ras0219-msft
requested changes
May 26, 2022
|
Dropped the feature and made openssl/boost hard dependencies |
Adela0814
approved these changes
Jun 6, 2022
Adela0814
added
info:reviewed
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Add hareflow to ports
What does your PR fix?
[New Port Request] hareflow #24902
Which triplets are supported/not supported? Have you updated the CI baseline?
all, No
Does your PR follow the maintainer guide?
YesIf you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes